UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: ufs-bsg: Wake the device before sending raw upiu commands 

The scsi async probe process is calling blk_pm_runtime_init for each lun,
and then those request queues are monitored by the block layer pm
engine (blk-pm.c).  This is however, not the case for scsi-passthrough
queues, created by bsg_setup_queue().

So the ufs-bsg driver might send various commands, disregarding the pm
status of the device. This is wrong, regardless if its request queue is
pm-aware or not.

Fixes: df032bf27a (scsi: ufs: Add a bsg endpoint that supports UPIUs)
Link: https://lore.kernel.org/r/1570696267-8487-1-git-send-email-avri.altman@wdc.com
Reported-by: Yuliy Izrailov <yuliy.izrailov@wdc.com>
Signed-off-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Avri Altman 2019-10-10 11:31:07 +03:00 committed by Martin K. Petersen
parent 535fb49e73
commit 74e5e468b6
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/ufs/ufs_bsg.c
View File

@ -98,6 +98,8 @@ static int ufs_bsg_request(struct bsg_job *job)
bsg_reply->reply_payload_rcv_len = 0; bsg_reply->reply_payload_rcv_len = 0;
pm_runtime_get_sync(hba->dev);
msgcode = bsg_request->msgcode; msgcode = bsg_request->msgcode;
switch (msgcode) { switch (msgcode) {
case UPIU_TRANSACTION_QUERY_REQ: case UPIU_TRANSACTION_QUERY_REQ:
@ -135,6 +137,8 @@ static int ufs_bsg_request(struct bsg_job *job)
break; break;
} }
pm_runtime_put_sync(hba->dev);
if (!desc_buff) if (!desc_buff)
goto out; goto out;