From 739752d655b3a5fa6ea3d72c1b53cec082f86486 Mon Sep 17 00:00:00 2001 From: Yang Yingliang Date: Wed, 24 Nov 2021 16:40:48 +0800 Subject: [PATCH] tsnep: Add missing of_node_put() in tsnep_mdio_init() The node pointer is returned by of_get_child_by_name() with refcount incremented in tsnep_mdio_init(). Calling of_node_put() to aovid the refcount leak in tsnep_mdio_init(). Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/r/20211124084048.175456-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/engleder/tsnep_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c index 955565a2a86c..904f3304727e 100644 --- a/drivers/net/ethernet/engleder/tsnep_main.c +++ b/drivers/net/ethernet/engleder/tsnep_main.c @@ -1089,9 +1089,10 @@ static int tsnep_mdio_init(struct tsnep_adapter *adapter) adapter->mdiobus->phy_mask = 0x0000001; retval = of_mdiobus_register(adapter->mdiobus, np); + +out: if (np) of_node_put(np); -out: return retval; }