UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

phy: qcom-qusb2: Use dev_err_probe() to simplify code 

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20220922111228.36355-7-yuancan@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Yuan Can 2022-09-22 11:12:27 +00:00 committed by Vinod Koul
parent a548b6b4e4
commit 72f1f6085a
1 changed files with 9 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/phy/qualcomm/phy-qcom-qusb2.c
View File

@ -973,20 +973,14 @@ static int qusb2_phy_probe(struct platform_device *pdev)
return PTR_ERR(qphy->base); return PTR_ERR(qphy->base);
qphy->cfg_ahb_clk = devm_clk_get(dev, "cfg_ahb"); qphy->cfg_ahb_clk = devm_clk_get(dev, "cfg_ahb");
if (IS_ERR(qphy->cfg_ahb_clk)) { if (IS_ERR(qphy->cfg_ahb_clk))
ret = PTR_ERR(qphy->cfg_ahb_clk); return dev_err_probe(dev, PTR_ERR(qphy->cfg_ahb_clk),
if (ret != -EPROBE_DEFER) "failed to get cfg ahb clk\n");
dev_err(dev, "failed to get cfg ahb clk, %d\n", ret);
return ret;
}
qphy->ref_clk = devm_clk_get(dev, "ref"); qphy->ref_clk = devm_clk_get(dev, "ref");
if (IS_ERR(qphy->ref_clk)) { if (IS_ERR(qphy->ref_clk))
ret = PTR_ERR(qphy->ref_clk); return dev_err_probe(dev, PTR_ERR(qphy->ref_clk),
if (ret != -EPROBE_DEFER) "failed to get ref clk\n");
dev_err(dev, "failed to get ref clk, %d\n", ret);
return ret;
}
qphy->iface_clk = devm_clk_get_optional(dev, "iface"); qphy->iface_clk = devm_clk_get_optional(dev, "iface");
if (IS_ERR(qphy->iface_clk)) if (IS_ERR(qphy->iface_clk))
@ -1003,12 +997,9 @@ static int qusb2_phy_probe(struct platform_device *pdev)
qphy->vregs[i].supply = qusb2_phy_vreg_names[i]; qphy->vregs[i].supply = qusb2_phy_vreg_names[i];
ret = devm_regulator_bulk_get(dev, num, qphy->vregs); ret = devm_regulator_bulk_get(dev, num, qphy->vregs);
if (ret) { if (ret)
if (ret != -EPROBE_DEFER) return dev_err_probe(dev, ret,
dev_err(dev, "failed to get regulator supplies: %d\n", "failed to get regulator supplies\n");
ret);
return ret;
}
/* Get the specific init parameters of QMP phy */ /* Get the specific init parameters of QMP phy */
qphy->cfg = of_device_get_match_data(dev); qphy->cfg = of_device_get_match_data(dev);