UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

dcbnl: Move dcb app lookup code into dcb_app_lookup() 

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Thomas Graf 2012-06-13 02:54:59 +00:00 committed by David S. Miller
parent 3d1f486952
commit 716b31abbd
1 changed files with 35 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
net/dcb/dcbnl.c
View File

@ -1716,6 +1716,22 @@ out:
return ret; return ret;
} }
static struct dcb_app_type *dcb_app_lookup(const struct dcb_app *app,
int ifindex, int prio)
{
struct dcb_app_type *itr;
list_for_each_entry(itr, &dcb_app_list, list) {
if (itr->app.selector == app->selector &&
itr->app.protocol == app->protocol &&
itr->ifindex == ifindex &&
(!prio || itr->app.priority == prio))
return itr;
}
return NULL;
}
/** /**
* dcb_getapp - retrieve the DCBX application user priority * dcb_getapp - retrieve the DCBX application user priority
* *
@ -1729,14 +1745,8 @@ u8 dcb_getapp(struct net_device *dev, struct dcb_app *app)
u8 prio = 0; u8 prio = 0;
spin_lock(&dcb_lock); spin_lock(&dcb_lock);
list_for_each_entry(itr, &dcb_app_list, list) { if ((itr = dcb_app_lookup(app, dev->ifindex, 0)))
if (itr->app.selector == app->selector && prio = itr->app.priority;
itr->app.protocol == app->protocol &&
itr->ifindex == dev->ifindex) {
prio = itr->app.priority;
break;
}
}
spin_unlock(&dcb_lock); spin_unlock(&dcb_lock);
return prio; return prio;
@ -1762,18 +1772,14 @@ int dcb_setapp(struct net_device *dev, struct dcb_app *new)
spin_lock(&dcb_lock); spin_lock(&dcb_lock);
/* Search for existing match and replace */ /* Search for existing match and replace */
list_for_each_entry(itr, &dcb_app_list, list) { if ((itr = dcb_app_lookup(new, dev->ifindex, 0))) {
if (itr->app.selector == new->selector && if (new->priority)
itr->app.protocol == new->protocol && itr->app.priority = new->priority;
itr->ifindex == dev->ifindex) { else {
if (new->priority) list_del(&itr->list);
itr->app.priority = new->priority; kfree(itr);
else {
list_del(&itr->list);
kfree(itr);
}
goto out;
} }
goto out;
} }
/* App type does not exist add new application type */ /* App type does not exist add new application type */
if (new->priority) { if (new->priority) {
@ -1808,13 +1814,8 @@ u8 dcb_ieee_getapp_mask(struct net_device *dev, struct dcb_app *app)
u8 prio = 0; u8 prio = 0;
spin_lock(&dcb_lock); spin_lock(&dcb_lock);
list_for_each_entry(itr, &dcb_app_list, list) { if ((itr = dcb_app_lookup(app, dev->ifindex, 0)))
if (itr->app.selector == app->selector && prio |= 1 << itr->app.priority;
itr->app.protocol == app->protocol &&
itr->ifindex == dev->ifindex) {
prio |= 1 << itr->app.priority;
}
}
spin_unlock(&dcb_lock); spin_unlock(&dcb_lock);
return prio; return prio;
@ -1830,7 +1831,7 @@ EXPORT_SYMBOL(dcb_ieee_getapp_mask);
*/ */
int dcb_ieee_setapp(struct net_device *dev, struct dcb_app *new) int dcb_ieee_setapp(struct net_device *dev, struct dcb_app *new)
{ {
struct dcb_app_type *itr, *entry; struct dcb_app_type *entry;
struct dcb_app_type event; struct dcb_app_type event;
int err = 0; int err = 0;
@ -1841,14 +1842,9 @@ int dcb_ieee_setapp(struct net_device *dev, struct dcb_app *new)
spin_lock(&dcb_lock); spin_lock(&dcb_lock);
/* Search for existing match and abort if found */ /* Search for existing match and abort if found */
list_for_each_entry(itr, &dcb_app_list, list) { if (dcb_app_lookup(new, dev->ifindex, new->priority)) {
if (itr->app.selector == new->selector && err = -EEXIST;
itr->app.protocol == new->protocol && goto out;
itr->app.priority == new->priority &&
itr->ifindex == dev->ifindex) {
err = -EEXIST;
goto out;
}
} }
/* App entry does not exist add new entry */ /* App entry does not exist add new entry */
@ -1887,19 +1883,12 @@ int dcb_ieee_delapp(struct net_device *dev, struct dcb_app *del)
spin_lock(&dcb_lock); spin_lock(&dcb_lock);
/* Search for existing match and remove it. */ /* Search for existing match and remove it. */
list_for_each_entry(itr, &dcb_app_list, list) { if ((itr = dcb_app_lookup(del, dev->ifindex, del->priority))) {
if (itr->app.selector == del->selector && list_del(&itr->list);
itr->app.protocol == del->protocol && kfree(itr);
itr->app.priority == del->priority && err = 0;
itr->ifindex == dev->ifindex) {
list_del(&itr->list);
kfree(itr);
err = 0;
goto out;
}
} }
out:
spin_unlock(&dcb_lock); spin_unlock(&dcb_lock);
if (!err) if (!err)
call_dcbevent_notifiers(DCB_APP_EVENT, &event); call_dcbevent_notifiers(DCB_APP_EVENT, &event);