UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

crypto: sun8i-ce - use kfree_sensitive() 

Use kfree_sensitive() instead of open-coding it.

Signed-off-by: Denis Efremov <efremov@linux.com>
Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Denis Efremov 2020-08-27 09:44:01 +03:00 committed by Herbert Xu
parent ba42fa77ef
commit 712d806957
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
View File

@ -366,10 +366,7 @@ void sun8i_ce_cipher_exit(struct crypto_tfm *tfm)
{ {
struct sun8i_cipher_tfm_ctx *op = crypto_tfm_ctx(tfm); struct sun8i_cipher_tfm_ctx *op = crypto_tfm_ctx(tfm);
if (op->key) { kfree_sensitive(op->key);
memzero_explicit(op->key, op->keylen);
kfree(op->key);
}
crypto_free_skcipher(op->fallback_tfm); crypto_free_skcipher(op->fallback_tfm);
pm_runtime_put_sync_suspend(op->ce->dev); pm_runtime_put_sync_suspend(op->ce->dev);
} }
@ -391,10 +388,7 @@ int sun8i_ce_aes_setkey(struct crypto_skcipher *tfm, const u8 *key,
dev_dbg(ce->dev, "ERROR: Invalid keylen %u\n", keylen); dev_dbg(ce->dev, "ERROR: Invalid keylen %u\n", keylen);
return -EINVAL; return -EINVAL;
} }
if (op->key) { kfree_sensitive(op->key);
memzero_explicit(op->key, op->keylen);
kfree(op->key);
}
op->keylen = keylen; op->keylen = keylen;
op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
if (!op->key) if (!op->key)
@ -416,10 +410,7 @@ int sun8i_ce_des3_setkey(struct crypto_skcipher *tfm, const u8 *key,
if (err) if (err)
return err; return err;
if (op->key) { kfree_sensitive(op->key);
memzero_explicit(op->key, op->keylen);
kfree(op->key);
}
op->keylen = keylen; op->keylen = keylen;
op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
if (!op->key) if (!op->key)