UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

leds-lp5523: change the return type of lp5523_set_mode() 

The return value of this function is not handled any place, so
make it as void type.

And three if-statements are replaced with switch-statements.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
This commit is contained in:
Kim, Milo 2012-08-21 17:03:58 +08:00 committed by Bryan Wu
parent a39b9854c7
commit 6f6365fbac
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/leds/leds-lp5523.c
View File

@ -150,7 +150,7 @@ static inline struct lp5523_chip *led_to_lp5523(struct lp5523_led *led)
leds[led->id]); leds[led->id]);
} }
static int lp5523_set_mode(struct lp5523_engine *engine, u8 mode); static void lp5523_set_mode(struct lp5523_engine *engine, u8 mode);
static int lp5523_set_engine_mode(struct lp5523_engine *engine, u8 mode); static int lp5523_set_engine_mode(struct lp5523_engine *engine, u8 mode);
static int lp5523_load_program(struct lp5523_engine *engine, const u8 *pattern); static int lp5523_load_program(struct lp5523_engine *engine, const u8 *pattern);
@ -789,26 +789,28 @@ static void lp5523_unregister_sysfs(struct i2c_client *client)
/*--------------------------------------------------------------*/ /*--------------------------------------------------------------*/
/* Set chip operating mode */ /* Set chip operating mode */
/*--------------------------------------------------------------*/ /*--------------------------------------------------------------*/
static int lp5523_set_mode(struct lp5523_engine *engine, u8 mode) static void lp5523_set_mode(struct lp5523_engine *engine, u8 mode)
{ {
int ret = 0;
/* if in that mode already do nothing, except for run */ /* if in that mode already do nothing, except for run */
if (mode == engine->mode && mode != LP5523_CMD_RUN) if (mode == engine->mode && mode != LP5523_CMD_RUN)
return 0; return;
if (mode == LP5523_CMD_RUN) { switch (mode) {
ret = lp5523_run_program(engine); case LP5523_CMD_RUN:
} else if (mode == LP5523_CMD_LOAD) { lp5523_run_program(engine);
break;
case LP5523_CMD_LOAD:
lp5523_set_engine_mode(engine, LP5523_CMD_DISABLED); lp5523_set_engine_mode(engine, LP5523_CMD_DISABLED);
lp5523_set_engine_mode(engine, LP5523_CMD_LOAD); lp5523_set_engine_mode(engine, LP5523_CMD_LOAD);
} else if (mode == LP5523_CMD_DISABLED) { break;
case LP5523_CMD_DISABLED:
lp5523_set_engine_mode(engine, LP5523_CMD_DISABLED); lp5523_set_engine_mode(engine, LP5523_CMD_DISABLED);
break;
default:
return;
} }
engine->mode = mode; engine->mode = mode;
return ret;
} }
/*--------------------------------------------------------------*/ /*--------------------------------------------------------------*/