From 6d45374af539c84d17cfcf5a4e96bc4b2ca421e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Date: Wed, 23 Jun 2021 16:02:39 +0200 Subject: [PATCH] pwm: ep93xx: Implement .apply callback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To ease review this reuses the formerly implemented callbacks. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- drivers/pwm/pwm-ep93xx.c | 43 ++++++++++++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c index 4ca70794ad96..3ef4b41bfd66 100644 --- a/drivers/pwm/pwm-ep93xx.c +++ b/drivers/pwm/pwm-ep93xx.c @@ -156,13 +156,48 @@ static void ep93xx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm) clk_disable(ep93xx_pwm->clk); } +static int ep93xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, + const struct pwm_state *state) +{ + int ret; + bool enabled = state->enabled; + + if (state->polarity != pwm->state.polarity) { + if (enabled) { + ep93xx_pwm_disable(chip, pwm); + enabled = false; + } + + ret = ep93xx_pwm_polarity(chip, pwm, state->polarity); + if (ret) + return ret; + } + + if (!state->enabled) { + if (enabled) + ep93xx_pwm_disable(chip, pwm); + + return 0; + } + + if (state->period != pwm->state.period || + state->duty_cycle != pwm->state.duty_cycle) { + ret = ep93xx_pwm_config(chip, pwm, (int)state->duty_cycle, + (int)state->period); + if (ret) + return ret; + } + + if (!enabled) + return ep93xx_pwm_enable(chip, pwm); + + return 0; +} + static const struct pwm_ops ep93xx_pwm_ops = { .request = ep93xx_pwm_request, .free = ep93xx_pwm_free, - .config = ep93xx_pwm_config, - .set_polarity = ep93xx_pwm_polarity, - .enable = ep93xx_pwm_enable, - .disable = ep93xx_pwm_disable, + .apply = ep93xx_pwm_apply, .owner = THIS_MODULE, };