UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: qedf: fixup locking in qedf_restart_rport() 

fc_rport_create() needs to be called with disc_mutex held.  And we should
re-assign the 'rdata' pointer in case it got changed.

Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Hannes Reinecke 2019-03-26 00:38:44 -07:00 committed by Martin K. Petersen
parent 4262d35c32
commit 6d1368e8f9
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/scsi/qedf/qedf_els.c
View File

@ -380,10 +380,16 @@ void qedf_restart_rport(struct qedf_rport *fcport)
QEDF_ERR(&(fcport->qedf->dbg_ctx), QEDF_ERR(&(fcport->qedf->dbg_ctx),
"LOGO port_id=%x.\n", port_id); "LOGO port_id=%x.\n", port_id);
fc_rport_logoff(rdata); fc_rport_logoff(rdata);
mutex_lock(&lport->disc.disc_mutex);
/* Recreate the rport and log back in */ /* Recreate the rport and log back in */
rdata = fc_rport_create(lport, port_id); rdata = fc_rport_create(lport, port_id);
if (rdata) if (rdata) {
mutex_unlock(&lport->disc.disc_mutex);
fc_rport_login(rdata); fc_rport_login(rdata);
fcport->rdata = rdata;
} else {
mutex_unlock(&lport->disc.disc_mutex);
}
} }
clear_bit(QEDF_RPORT_IN_RESET, &fcport->flags); clear_bit(QEDF_RPORT_IN_RESET, &fcport->flags);
} }