UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: greybus: codecs: use dedicated list iterator variable 

In preparation to limit the scope of the list iterator to the list
traversal loop, use a dedicated pointer to point to the found element [1].

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220321123712.3068778-1-jakobkoschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jakob Koschel 2022-03-21 13:37:12 +01:00 committed by Greg Kroah-Hartman
parent 77714e53dd
commit 6c73d3203c
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/staging/greybus/audio_codec.c
View File

@ -497,7 +497,7 @@ static int gbcodec_prepare(struct snd_pcm_substream *substream,
struct snd_soc_dai *dai) struct snd_soc_dai *dai)
{ {
int ret; int ret;
struct gbaudio_module_info *module; struct gbaudio_module_info *module = NULL, *iter;
struct gbaudio_data_connection *data; struct gbaudio_data_connection *data;
struct gb_bundle *bundle; struct gb_bundle *bundle;
struct gbaudio_codec_info *codec = dev_get_drvdata(dai->dev); struct gbaudio_codec_info *codec = dev_get_drvdata(dai->dev);
@ -511,12 +511,14 @@ static int gbcodec_prepare(struct snd_pcm_substream *substream,
return -ENODEV; return -ENODEV;
} }
list_for_each_entry(module, &codec->module_list, list) { list_for_each_entry(iter, &codec->module_list, list) {
/* find the dai */ /* find the dai */
data = find_data(module, dai->id); data = find_data(iter, dai->id);
if (data) if (data) {
module = iter;
break; break;
} }
}
if (!data) { if (!data) {
dev_err(dai->dev, "DATA connection missing\n"); dev_err(dai->dev, "DATA connection missing\n");
mutex_unlock(&codec->lock); mutex_unlock(&codec->lock);
@ -563,7 +565,7 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
{ {
int ret; int ret;
struct gbaudio_data_connection *data; struct gbaudio_data_connection *data;
struct gbaudio_module_info *module; struct gbaudio_module_info *module = NULL, *iter;
struct gb_bundle *bundle; struct gb_bundle *bundle;
struct gbaudio_codec_info *codec = dev_get_drvdata(dai->dev); struct gbaudio_codec_info *codec = dev_get_drvdata(dai->dev);
struct gbaudio_stream_params *params; struct gbaudio_stream_params *params;
@ -592,12 +594,14 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
return ret; return ret;
} }
list_for_each_entry(module, &codec->module_list, list) { list_for_each_entry(iter, &codec->module_list, list) {
/* find the dai */ /* find the dai */
data = find_data(module, dai->id); data = find_data(iter, dai->id);
if (data) if (data) {
module = iter;
break; break;
} }
}
if (!data) { if (!data) {
dev_err(dai->dev, "%s:%s DATA connection missing\n", dev_err(dai->dev, "%s:%s DATA connection missing\n",
dai->name, module->name); dai->name, module->name);