UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: comedi: comedi_fops: remove BUG_ON() in comedi_cleanup() 

The BUG_ON() checks in this function are not necessary.

comedi_cleanup_board_minors() clears all the entries in the
comedi_board_minor_table array and will call comedi_device_cleanup()
for all attached devices. comedi_device_cleanup() will then
clear the entries in the comedi_subdevice_minor_table array with
comedi_free_subdevice_minor().

Remove the BUG_ON(), drivers should not crash the kernel.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-08-10 13:14:02 -07:00 committed by Greg Kroah-Hartman
parent 0bb6419ccf
commit 6b3703f4cb
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/comedi/comedi_fops.c
View File

@ -2930,14 +2930,7 @@ module_init(comedi_init);
static void __exit comedi_cleanup(void)
{
int i;
comedi_cleanup_board_minors();
for (i = 0; i < COMEDI_NUM_BOARD_MINORS; ++i)
BUG_ON(comedi_board_minor_table[i]);
for (i = 0; i < COMEDI_NUM_SUBDEVICE_MINORS; ++i)
BUG_ON(comedi_subdevice_minor_table[i]);
class_destroy(comedi_class);
cdev_del(&comedi_cdev);
unregister_chrdev_region(MKDEV(COMEDI_MAJOR, 0), COMEDI_NUM_MINORS);