UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: iscsi: Make iscsi_unregister_transport() return void 

This function always returns 0. We can make it return void to simplify the
code. Also, no caller ever checks the return value of this function.

Link: https://lore.kernel.org/r/20220616080210.18531-1-mgurtovoy@nvidia.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Max Gurtovoy 2022-06-16 11:02:10 +03:00 committed by Martin K. Petersen
parent cb142b6d2f
commit 6a33ed5064
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/scsi_transport_iscsi.c
View File

@ -4807,7 +4807,7 @@ free_priv:
} }
EXPORT_SYMBOL_GPL(iscsi_register_transport); EXPORT_SYMBOL_GPL(iscsi_register_transport);
int iscsi_unregister_transport(struct iscsi_transport *tt) void iscsi_unregister_transport(struct iscsi_transport *tt)
{ {
struct iscsi_internal *priv; struct iscsi_internal *priv;
unsigned long flags; unsigned long flags;
@ -4830,8 +4830,6 @@ int iscsi_unregister_transport(struct iscsi_transport *tt)
sysfs_remove_group(&priv->dev.kobj, &iscsi_transport_group); sysfs_remove_group(&priv->dev.kobj, &iscsi_transport_group);
device_unregister(&priv->dev); device_unregister(&priv->dev);
mutex_unlock(&rx_queue_mutex); mutex_unlock(&rx_queue_mutex);
return 0;
} }
EXPORT_SYMBOL_GPL(iscsi_unregister_transport); EXPORT_SYMBOL_GPL(iscsi_unregister_transport);

2
include/scsi/scsi_transport_iscsi.h
View File

@ -162,7 +162,7 @@ struct iscsi_transport {
* transport registration upcalls * transport registration upcalls
*/ */
extern struct scsi_transport_template *iscsi_register_transport(struct iscsi_transport *tt); extern struct scsi_transport_template *iscsi_register_transport(struct iscsi_transport *tt);
extern int iscsi_unregister_transport(struct iscsi_transport *tt); extern void iscsi_unregister_transport(struct iscsi_transport *tt);
/* /*
* control plane upcalls * control plane upcalls