UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

spi: spi-tegra20-sflash: remove redundant irqsave and irqrestore in hardIRQ 

Running in hardIRQ, disabling IRQ is redundant.

Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Link: https://lore.kernel.org/r/20200926001616.21292-1-song.bao.hua@hisilicon.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Barry Song 2020-09-26 12:16:15 +12:00 committed by Mark Brown
parent 23f370c748
commit 69544f2c15
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/spi/spi-tegra20-sflash.c
View File

@ -359,9 +359,8 @@ exit:
static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd) static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd)
{ {
struct spi_transfer *t = tsd->curr_xfer; struct spi_transfer *t = tsd->curr_xfer;
unsigned long flags;
spin_lock_irqsave(&tsd->lock, flags); spin_lock(&tsd->lock);
if (tsd->tx_status || tsd->rx_status || (tsd->status_reg & SPI_BSY)) { if (tsd->tx_status || tsd->rx_status || (tsd->status_reg & SPI_BSY)) {
dev_err(tsd->dev, dev_err(tsd->dev,
"CpuXfer ERROR bit set 0x%x\n", tsd->status_reg); "CpuXfer ERROR bit set 0x%x\n", tsd->status_reg);
@ -391,7 +390,7 @@ static irqreturn_t handle_cpu_based_xfer(struct tegra_sflash_data *tsd)
tegra_sflash_calculate_curr_xfer_param(tsd->cur_spi, tsd, t); tegra_sflash_calculate_curr_xfer_param(tsd->cur_spi, tsd, t);
tegra_sflash_start_cpu_based_transfer(tsd, t); tegra_sflash_start_cpu_based_transfer(tsd, t);
exit: exit:
spin_unlock_irqrestore(&tsd->lock, flags); spin_unlock(&tsd->lock);
return IRQ_HANDLED; return IRQ_HANDLED;
} }