UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: add BUG_ON if kernel advertises msg_namelen > sizeof(struct sockaddr_storage) 

In that case it is probable that kernel code overwrote part of the
stack. So we should bail out loudly here.

The BUG_ON may be removed in future if we are sure all protocols are
conformant.

Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Hannes Frederic Sowa 2013-11-21 03:14:34 +01:00 committed by David S. Miller
parent f3d3342602
commit 68c6beb373
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/socket.c
View File

@ -221,12 +221,13 @@ static int move_addr_to_user(struct sockaddr_storage *kaddr, int klen,
int err; int err;
int len; int len;
BUG_ON(klen > sizeof(struct sockaddr_storage));
err = get_user(len, ulen); err = get_user(len, ulen);
if (err) if (err)
return err; return err;
if (len > klen) if (len > klen)
len = klen; len = klen;
if (len < 0 || len > sizeof(struct sockaddr_storage)) if (len < 0)
return -EINVAL; return -EINVAL;
if (len) { if (len) {
if (audit_sockaddr(klen, kaddr)) if (audit_sockaddr(klen, kaddr))