UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

greybus: connection: destroy connection on failing to bind it 

gb_connection_bind_protocol() returns proper error codes now and we
should destroy the connection on failures.

This change also fixes a NULL deref on hotplug when the control connection fails
to initialize.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Fabien Parent 2015-10-13 17:34:51 +02:00 committed by Greg Kroah-Hartman
parent 82ee1e6cde
commit 67b81757da
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/greybus/connection.c
View File

@ -239,7 +239,14 @@ gb_connection_create_range(struct greybus_host_device *hd,
spin_unlock_irq(&gb_connections_lock);
gb_connection_bind_protocol(connection);
retval = gb_connection_bind_protocol(connection);
if (retval) {
dev_err(&connection->dev, "failed to bind protocol: %d\n",
retval);
gb_connection_destroy(connection);
return NULL;
}
if (!connection->protocol)
dev_warn(&connection->dev,
"protocol 0x%02hhx handler not found\n", protocol_id);