UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: most: convert macro to static function 

This fixes checkpatch warning:
CHECK: Macro argument reuse 'buf' - possible side effects?

Signed-off-by: George Edward Bulmer <gebulmer@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
George Edward Bulmer 2017-12-29 21:26:20 +00:00 committed by Greg Kroah-Hartman
parent 9917b209f8
commit 6724ed7f28
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/most/net/net.c
View File

@ -46,10 +46,12 @@
((len) > MEP_HDR_LEN && \
EXTRACT_BIT_SET(PMS_FIFONO, (buf)[3]) == PMS_FIFONO_MEP)
#define PMS_IS_MAMAC(buf, len) \
((len) > MDP_HDR_LEN && \
EXTRACT_BIT_SET(PMS_FIFONO, (buf)[3]) == PMS_FIFONO_MDP && \
EXTRACT_BIT_SET(PMS_TELID, (buf)[14]) == PMS_TELID_UNSEGM_MAMAC)
static inline bool pms_is_mamac(char *buf, u32 len)
{
return (len > MDP_HDR_LEN &&
EXTRACT_BIT_SET(PMS_FIFONO, buf[3]) == PMS_FIFONO_MDP &&
EXTRACT_BIT_SET(PMS_TELID, buf[14]) == PMS_TELID_UNSEGM_MAMAC);
}
struct net_dev_channel {
bool linked;
@ -435,7 +437,7 @@ static int comp_rx_data(struct mbo *mbo)
dev = nd->dev;
if (nd->is_mamac) {
if (!PMS_IS_MAMAC(buf, len)) {
if (!pms_is_mamac(buf, len)) {
ret = -EIO;
goto put_nd;
}