UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

crypto: hisilicon/hpre - fix "hpre_ctx_init" resource leak 

When calling "hpre_ctx_set" fails, stop and put qp,
otherwise will leak qp resource.

Signed-off-by: Hui Tang <tanghui20@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Hui Tang 2021-03-19 18:45:27 +08:00 committed by Herbert Xu
parent a9214b0b6e
commit 670fefb924
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/crypto/hisilicon/hpre/hpre_crypto.c
View File

@ -454,9 +454,16 @@ static void hpre_alg_cb(struct hisi_qp *qp, void *resp)
req->cb(ctx, resp); req->cb(ctx, resp);
} }
static void hpre_stop_qp_and_put(struct hisi_qp *qp)
{
hisi_qm_stop_qp(qp);
hisi_qm_free_qps(&qp, 1);
}
static int hpre_ctx_init(struct hpre_ctx *ctx, u8 type) static int hpre_ctx_init(struct hpre_ctx *ctx, u8 type)
{ {
struct hisi_qp *qp; struct hisi_qp *qp;
int ret;
qp = hpre_get_qp_and_start(type); qp = hpre_get_qp_and_start(type);
if (IS_ERR(qp)) if (IS_ERR(qp))
@ -465,7 +472,11 @@ static int hpre_ctx_init(struct hpre_ctx *ctx, u8 type)
qp->qp_ctx = ctx; qp->qp_ctx = ctx;
qp->req_cb = hpre_alg_cb; qp->req_cb = hpre_alg_cb;
return hpre_ctx_set(ctx, qp, QM_Q_DEPTH); ret = hpre_ctx_set(ctx, qp, QM_Q_DEPTH);
if (ret)
hpre_stop_qp_and_put(qp);
return ret;
} }
static int hpre_msg_request_set(struct hpre_ctx *ctx, void *req, bool is_rsa) static int hpre_msg_request_set(struct hpre_ctx *ctx, void *req, bool is_rsa)