UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

checkpatch: add Signed-off-by check if commit cherry-pick from upstream 

When a commit cherry-pick from upstream, we should add Signed-off-by in
commit message. With the Signed-off-by info, we could easy to know who
picked the commit, and could ask him the reason: why we need pick the commit.

Signed-off-by: Jianping Liu <frankjpliu@tencent.com>
Reviewed-by: Yongliang Gao <leonylgao@tencent.com>
This commit is contained in:
Jianping Liu 2024-03-27 16:59:08 +08:00
parent f55a71cb98
commit 66d114febb
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
scripts/checkpatch.pl
View File

@ -7723,10 +7723,16 @@ sub process {
"From:/Signed-off-by: email subaddress mismatch: $sob_msg\n");
}
}
if ($author !~ /tencent/ && $tencentsign != 0 && $tencentbackport == 0) {
# It's a backport commit, needs a cid reference
WARN("NO_BACKPORT_REF",
"Missing backport reference 'commit xxx upstream' ?\n");
if ($author !~ /tencent.com/) {
if ($tencentsign == 0) {
WARN("BAD_SIGN_OFF",
"If this commit cherry-pick from upstream, must add Signed-off-by: <*tencent.com> !\n");
}
if ($tencentbackport == 0) {
# It's a backport commit, needs a cid reference
WARN("NO_BACKPORT_REF",
"If this commit cherry-pick from upstream, must add upstream commid, eg: 'commit xxx upstream.' !\n");
}
}
}