[PATCH] session_of_pgrp: kill unnecessary do_each_task_pid(PIDTYPE_PGID)
All members of the process group have the same sid and it can't be == 0.
NOTE: this code (and a similar one in sys_setpgid) was needed because it
was possibe to have ->session == 0. It's not possible any longer since
[PATCH] pidhash: don't use zero pids
Commit: c7c6464117
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
f020bc468f
commit
62dfb5541a
|
@ -189,21 +189,18 @@ repeat:
|
||||||
int session_of_pgrp(int pgrp)
|
int session_of_pgrp(int pgrp)
|
||||||
{
|
{
|
||||||
struct task_struct *p;
|
struct task_struct *p;
|
||||||
int sid = -1;
|
int sid = 0;
|
||||||
|
|
||||||
read_lock(&tasklist_lock);
|
read_lock(&tasklist_lock);
|
||||||
do_each_task_pid(pgrp, PIDTYPE_PGID, p) {
|
|
||||||
if (process_session(p) > 0) {
|
p = find_task_by_pid_type(PIDTYPE_PGID, pgrp);
|
||||||
sid = process_session(p);
|
if (p == NULL)
|
||||||
goto out;
|
p = find_task_by_pid(pgrp);
|
||||||
}
|
if (p != NULL)
|
||||||
} while_each_task_pid(pgrp, PIDTYPE_PGID, p);
|
|
||||||
p = find_task_by_pid(pgrp);
|
|
||||||
if (p)
|
|
||||||
sid = process_session(p);
|
sid = process_session(p);
|
||||||
out:
|
|
||||||
read_unlock(&tasklist_lock);
|
read_unlock(&tasklist_lock);
|
||||||
|
|
||||||
return sid;
|
return sid;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue