UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

[media] em28xx: simplify argument passing to em28xx_init_dev() 

The 'struct em28xx *' pointer was passed by reference to the
em28xx_init_dev() function, for no reason. Instead, just pass it by
value, which is much more logical and simple.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Thomas Petazzoni 2012-01-07 10:18:45 -03:00 committed by Mauro Carvalho Chehab
parent d07b901f9d
commit 622c2fc1f2
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/media/video/em28xx/em28xx-cards.c
View File

@ -2916,11 +2916,10 @@ void em28xx_release_resources(struct em28xx *dev)
* em28xx_init_dev() * em28xx_init_dev()
* allocates and inits the device structs, registers i2c bus and v4l device * allocates and inits the device structs, registers i2c bus and v4l device
*/ */
static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev, static int em28xx_init_dev(struct em28xx *dev, struct usb_device *udev,
struct usb_interface *interface, struct usb_interface *interface,
int minor) int minor)
{ {
struct em28xx *dev = *devhandle;
int retval; int retval;
dev->udev = udev; dev->udev = udev;
@ -3302,7 +3301,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
/* allocate device struct */ /* allocate device struct */
mutex_init(&dev->lock); mutex_init(&dev->lock);
mutex_lock(&dev->lock); mutex_lock(&dev->lock);
retval = em28xx_init_dev(&dev, udev, interface, nr); retval = em28xx_init_dev(dev, udev, interface, nr);
if (retval) { if (retval) {
goto unlock_and_free; goto unlock_and_free;
} }