From 621da4ba0e244ba3cfb2e8a9a9055299ec0ab0d3 Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Thu, 22 Aug 2019 13:46:09 +0900 Subject: [PATCH] kbuild: Inform user to pass ARCH= for make mrproper only when necessary Since commit 3a475b2166fd ("kbuild: Inform user to pass ARCH= for make mrproper"), if you try out-of-tree build with an unclean source tree, it suggests to run 'make ARCH= mrproper'. This looks odd when you are not cross-compiling the kernel. Show the 'ARCH=' part only when ARCH= was given from the command line. If ARCH is the default (native build) or came from the environment, it should simply suggest 'make mrproper' as before. Signed-off-by: Masahiro Yamada --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c79c85126f0c..d5d0742efeb2 100644 --- a/Makefile +++ b/Makefile @@ -1118,7 +1118,7 @@ ifdef building_out_of_srctree $(Q)if [ -f $(srctree)/.config -o \ -d $(srctree)/include/config -o \ -d $(srctree)/arch/$(SRCARCH)/include/generated ]; then \ - echo >&2 " $(srctree) is not clean, please run 'make ARCH=$(ARCH) mrproper'"; \ + echo >&2 " $(srctree) is not clean, please run 'make$(if $(findstring command line, $(origin ARCH)), ARCH=$(ARCH)) mrproper'"; \ echo >&2 " in the '$(srctree)' directory.";\ /bin/false; \ fi;