UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

powerpc/82xx: Delete an unnecessary of_node_put() call in pq2ads_pci_init_irq() 

A null pointer would be passed to a call of the function “of_node_put”
immediately after a call of the function “of_find_compatible_node” failed
at one place.
Remove this superfluous function call.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/9c060a41-438b-6fb8-d549-37c72fae4898@web.de
This commit is contained in:
Markus Elfring 2019-08-27 08:44:20 +02:00 committed by Michael Ellerman
parent 6e7a4da754
commit 60aece4164
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
arch/powerpc/platforms/82xx/pq2ads-pci-pic.c
View File

@ -123,7 +123,6 @@ int __init pq2ads_pci_init_irq(void)
np = of_find_compatible_node(NULL, NULL, "fsl,pq2ads-pci-pic"); np = of_find_compatible_node(NULL, NULL, "fsl,pq2ads-pci-pic");
if (!np) { if (!np) {
printk(KERN_ERR "No pci pic node in device tree.\n"); printk(KERN_ERR "No pci pic node in device tree.\n");
of_node_put(np);
goto out; goto out;
} }