watchdog: imx2_wdt.c: use devm_request_and_ioremap
Reimplement a call to devm_request_mem_region followed by a call to ioremap or ioremap_nocache by a call to devm_request_and_ioremap. The variable res_size is then no longer needed. The semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // <smpl> @nm@ expression myname; identifier i; @@ struct platform_driver i = { .driver = { .name = myname } }; @@ expression dev,res,size; expression nm.myname; @@ -if (!devm_request_mem_region(dev, res->start, size, - \(res->name\|dev_name(dev)\|myname\))) { - ... - return ...; -} ... when != res->start ( -devm_ioremap(dev,res->start,size) +devm_request_and_ioremap(dev,res) | -devm_ioremap_nocache(dev,res->start,size) +devm_request_and_ioremap(dev,res) ) ... when any when != res->start // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
This commit is contained in:
parent
74ea15d909
commit
5d32d4868a
|
@ -247,7 +247,6 @@ static struct miscdevice imx2_wdt_miscdev = {
|
|||
static int __init imx2_wdt_probe(struct platform_device *pdev)
|
||||
{
|
||||
int ret;
|
||||
int res_size;
|
||||
struct resource *res;
|
||||
|
||||
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
||||
|
@ -256,15 +255,7 @@ static int __init imx2_wdt_probe(struct platform_device *pdev)
|
|||
return -ENODEV;
|
||||
}
|
||||
|
||||
res_size = resource_size(res);
|
||||
if (!devm_request_mem_region(&pdev->dev, res->start, res_size,
|
||||
res->name)) {
|
||||
dev_err(&pdev->dev, "can't allocate %d bytes at %d address\n",
|
||||
res_size, res->start);
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
imx2_wdt.base = devm_ioremap_nocache(&pdev->dev, res->start, res_size);
|
||||
imx2_wdt.base = devm_request_and_ioremap(&pdev->dev, res);
|
||||
if (!imx2_wdt.base) {
|
||||
dev_err(&pdev->dev, "ioremap failed\n");
|
||||
return -ENOMEM;
|
||||
|
|
Loading…
Reference in New Issue