UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

s390/tape: fix stringop-truncation gcc 8 warnings 

Use strlcpy to make sure strings are NUL-terminated. Fixes the following
gcc 8 warning:

inlined from 'register_tape_dev' at drivers/s390/char/tape_class.c:57:2:
./include/linux/string.h:246:9: warning: '__builtin_strncpy' specified
bound 32 equals destination size [-Wstringop-truncation]

Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Vasily Gorbik 2018-06-18 22:49:32 +02:00 committed by Martin Schwidefsky
parent 3ad4c05a53
commit 5d2f6e26b3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/s390/char/tape_class.c
View File

@ -54,10 +54,10 @@ struct tape_class_device *register_tape_dev(
if (!tcd) if (!tcd)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
strncpy(tcd->device_name, device_name, TAPECLASS_NAME_LEN); strlcpy(tcd->device_name, device_name, TAPECLASS_NAME_LEN);
for (s = strchr(tcd->device_name, '/'); s; s = strchr(s, '/')) for (s = strchr(tcd->device_name, '/'); s; s = strchr(s, '/'))
*s = '!'; *s = '!';
strncpy(tcd->mode_name, mode_name, TAPECLASS_NAME_LEN); strlcpy(tcd->mode_name, mode_name, TAPECLASS_NAME_LEN);
for (s = strchr(tcd->mode_name, '/'); s; s = strchr(s, '/')) for (s = strchr(tcd->mode_name, '/'); s; s = strchr(s, '/'))
*s = '!'; *s = '!';