UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

tty: serial: simplify qcom_geni_serial_send_chunk_fifo() 

* use memcpy() instead of the loop (removes c variable)
* use remaining parameter directly (removes chunk variable)

The code is simpler and easier to follow.

Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230420093514.13055-1-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jiri Slaby (SUSE) 2023-04-20 11:35:14 +02:00 committed by Greg Kroah-Hartman
parent 254d5a5946
commit 5c7e105cd1
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/tty/serial/qcom_geni_serial.c
View File

@ -854,21 +854,19 @@ static void qcom_geni_serial_stop_tx(struct uart_port *uport)
} }
static void qcom_geni_serial_send_chunk_fifo(struct uart_port *uport, static void qcom_geni_serial_send_chunk_fifo(struct uart_port *uport,
unsigned int chunk) unsigned int remaining)
{ {
struct qcom_geni_serial_port *port = to_dev_port(uport); struct qcom_geni_serial_port *port = to_dev_port(uport);
struct circ_buf *xmit = &uport->state->xmit; struct circ_buf *xmit = &uport->state->xmit;
unsigned int tx_bytes, c, remaining = chunk; unsigned int tx_bytes;
u8 buf[BYTES_PER_FIFO_WORD]; u8 buf[BYTES_PER_FIFO_WORD];
while (remaining) { while (remaining) {
memset(buf, 0, sizeof(buf)); memset(buf, 0, sizeof(buf));
tx_bytes = min(remaining, BYTES_PER_FIFO_WORD); tx_bytes = min(remaining, BYTES_PER_FIFO_WORD);
for (c = 0; c < tx_bytes ; c++) { memcpy(buf, &xmit->buf[xmit->tail], tx_bytes);
buf[c] = xmit->buf[xmit->tail]; uart_xmit_advance(uport, tx_bytes);
uart_xmit_advance(uport, 1);
}
iowrite32_rep(uport->membase + SE_GENI_TX_FIFOn, buf, 1); iowrite32_rep(uport->membase + SE_GENI_TX_FIFOn, buf, 1);