ASoC: codecs: lpass-rx-macro: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-50-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-15 16:05:41 +01:00 committed by Mark Brown
parent 8756b2ecbd
commit 5b06877205
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 4 deletions

View File

@ -3639,7 +3639,7 @@ err:
return ret; return ret;
} }
static int rx_macro_remove(struct platform_device *pdev) static void rx_macro_remove(struct platform_device *pdev)
{ {
struct rx_macro *rx = dev_get_drvdata(&pdev->dev); struct rx_macro *rx = dev_get_drvdata(&pdev->dev);
@ -3650,8 +3650,6 @@ static int rx_macro_remove(struct platform_device *pdev)
clk_disable_unprepare(rx->dcodec); clk_disable_unprepare(rx->dcodec);
lpass_macro_pds_exit(rx->pds); lpass_macro_pds_exit(rx->pds);
return 0;
} }
static const struct of_device_id rx_macro_dt_match[] = { static const struct of_device_id rx_macro_dt_match[] = {
@ -3723,7 +3721,7 @@ static struct platform_driver rx_macro_driver = {
.pm = &rx_macro_pm_ops, .pm = &rx_macro_pm_ops,
}, },
.probe = rx_macro_probe, .probe = rx_macro_probe,
.remove = rx_macro_remove, .remove_new = rx_macro_remove,
}; };
module_platform_driver(rx_macro_driver); module_platform_driver(rx_macro_driver);