powerpc/perf: Reject EBB events which specify a sample_type

Although we already block EBB events which request sampling using
sample_period, technically it's possible for an event to set sample_type
but not sample_period.

Nothing terrible will happen if an EBB event does specify sample_type,
but it signals a major confusion on the part of userspace, and so we do
them the favor of rejecting it.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
Michael Ellerman 2014-03-14 16:00:30 +11:00 committed by Benjamin Herrenschmidt
parent c2e37a2626
commit 58b5fb0049
1 changed files with 5 additions and 2 deletions

View File

@ -503,8 +503,11 @@ static int ebb_event_check(struct perf_event *event)
if (!leader->attr.pinned || !leader->attr.exclusive) if (!leader->attr.pinned || !leader->attr.exclusive)
return -EINVAL; return -EINVAL;
if (event->attr.inherit || event->attr.sample_period || if (event->attr.freq ||
event->attr.enable_on_exec || event->attr.freq) event->attr.inherit ||
event->attr.sample_type ||
event->attr.sample_period ||
event->attr.enable_on_exec)
return -EINVAL; return -EINVAL;
} }