staging: vc04_services: vchiq_arm: fix error return code of vchiq_release_internal() and vchiq_use_internal()
When arm_state is NULL, no error return code of vchiq_release_internal() and vchiq_use_internal() is assigned. To fix this bug, ret is assigned with VCHIQ_ERROR. Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Link: https://lore.kernel.org/r/20210306132245.16811-1-baijiaju1990@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
275b6bd538
commit
5866bce00d
|
@ -2332,8 +2332,10 @@ vchiq_use_internal(struct vchiq_state *state, struct vchiq_service *service,
|
|||
int *entity_uc;
|
||||
int local_uc;
|
||||
|
||||
if (!arm_state)
|
||||
if (!arm_state) {
|
||||
ret = VCHIQ_ERROR;
|
||||
goto out;
|
||||
}
|
||||
|
||||
vchiq_log_trace(vchiq_susp_log_level, "%s", __func__);
|
||||
|
||||
|
@ -2389,8 +2391,10 @@ vchiq_release_internal(struct vchiq_state *state, struct vchiq_service *service)
|
|||
char entity[16];
|
||||
int *entity_uc;
|
||||
|
||||
if (!arm_state)
|
||||
if (!arm_state) {
|
||||
ret = VCHIQ_ERROR;
|
||||
goto out;
|
||||
}
|
||||
|
||||
vchiq_log_trace(vchiq_susp_log_level, "%s", __func__);
|
||||
|
||||
|
|
Loading…
Reference in New Issue