UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ptp_qoriq: don't pass a large struct by value but instead pass it by reference 

Passing the struct ptp_clock_info caps by parameter is passing over 130 bytes
of data by value on the stack. Optimize this by passing it by reference instead.
Also shinks the object code size:

Before:
   text	   data	    bss	    dec	    hex	filename
  12596	   2160	     64	  14820	   39e4	drivers/ptp/ptp_qoriq.o

After:
   text	   data	    bss	    dec	    hex	filename
  12567	   2160	     64	  14791	   39c7	drivers/ptp/ptp_qoriq.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Colin Ian King 2019-02-19 14:21:20 +00:00 committed by David S. Miller
parent d2cf821ff6
commit 58066ac9d7
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/freescale/enetc/enetc_ptp.c
View File

@ -92,7 +92,7 @@ static int enetc_ptp_probe(struct pci_dev *pdev,
ptp_qoriq->dev = &pdev->dev; ptp_qoriq->dev = &pdev->dev;
err = ptp_qoriq_init(ptp_qoriq, base, enetc_ptp_caps); err = ptp_qoriq_init(ptp_qoriq, base, &enetc_ptp_caps);
if (err) if (err)
goto err_no_clock; goto err_no_clock;

6
drivers/ptp/ptp_qoriq.c
View File

@ -459,7 +459,7 @@ static int ptp_qoriq_auto_config(struct ptp_qoriq *ptp_qoriq,
} }
int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base, int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base,
const struct ptp_clock_info caps) const struct ptp_clock_info *caps)
{ {
struct device_node *node = ptp_qoriq->dev->of_node; struct device_node *node = ptp_qoriq->dev->of_node;
struct ptp_qoriq_registers *regs; struct ptp_qoriq_registers *regs;
@ -468,7 +468,7 @@ int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base,
u32 tmr_ctrl; u32 tmr_ctrl;
ptp_qoriq->base = base; ptp_qoriq->base = base;
ptp_qoriq->caps = caps; ptp_qoriq->caps = *caps;
if (of_property_read_u32(node, "fsl,cksel", &ptp_qoriq->cksel)) if (of_property_read_u32(node, "fsl,cksel", &ptp_qoriq->cksel))
ptp_qoriq->cksel = DEFAULT_CKSEL; ptp_qoriq->cksel = DEFAULT_CKSEL;
@ -605,7 +605,7 @@ static int ptp_qoriq_probe(struct platform_device *dev)
goto no_ioremap; goto no_ioremap;
} }
err = ptp_qoriq_init(ptp_qoriq, base, ptp_qoriq_caps); err = ptp_qoriq_init(ptp_qoriq, base, &ptp_qoriq_caps);
if (err) if (err)
goto no_clock; goto no_clock;

2
include/linux/fsl/ptp_qoriq.h
View File

@ -183,7 +183,7 @@ static inline void qoriq_write_le(unsigned __iomem *addr, u32 val)
irqreturn_t ptp_qoriq_isr(int irq, void *priv); irqreturn_t ptp_qoriq_isr(int irq, void *priv);
int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base, int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base,
const struct ptp_clock_info caps); const struct ptp_clock_info *caps);
void ptp_qoriq_free(struct ptp_qoriq *ptp_qoriq); void ptp_qoriq_free(struct ptp_qoriq *ptp_qoriq);
int ptp_qoriq_adjfine(struct ptp_clock_info *ptp, long scaled_ppm); int ptp_qoriq_adjfine(struct ptp_clock_info *ptp, long scaled_ppm);
int ptp_qoriq_adjtime(struct ptp_clock_info *ptp, s64 delta); int ptp_qoriq_adjtime(struct ptp_clock_info *ptp, s64 delta);