selftests/bpf: Prevent out-of-bounds stack access in test_bpffs
Buf can be not zero-terminated leading to strstr() to access data beyond the intended buf[] array. Fix by forcing zero termination. Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Link: https://lore.kernel.org/bpf/20211124002325.1737739-12-andrii@kernel.org
This commit is contained in:
parent
e2e0d90c55
commit
57428298b5
|
@ -19,11 +19,13 @@ static int read_iter(char *file)
|
|||
fd = open(file, 0);
|
||||
if (fd < 0)
|
||||
return -1;
|
||||
while ((len = read(fd, buf, sizeof(buf))) > 0)
|
||||
while ((len = read(fd, buf, sizeof(buf))) > 0) {
|
||||
buf[sizeof(buf) - 1] = '\0';
|
||||
if (strstr(buf, "iter")) {
|
||||
close(fd);
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
close(fd);
|
||||
return -1;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue