UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: brcm80211: fix memory leaks 

Free resources before exit.

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Alexander Beregalov 2011-03-13 21:58:47 +03:00 committed by Greg Kroah-Hartman
parent ab42abf33a
commit 570edd3b23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
View File

@ -5641,6 +5641,10 @@ static int dhdsdio_download_code_array(struct dhd_bus *bus)
unsigned char *ularray; unsigned char *ularray;
ularray = kmalloc(bus->ramsize, GFP_ATOMIC); ularray = kmalloc(bus->ramsize, GFP_ATOMIC);
if (!ularray) {
bcmerror = BCME_NOMEM;
goto err;
}
/* Upload image to verify downloaded contents. */ /* Upload image to verify downloaded contents. */
offset = 0; offset = 0;
memset(ularray, 0xaa, bus->ramsize); memset(ularray, 0xaa, bus->ramsize);
@ -5652,7 +5656,7 @@ static int dhdsdio_download_code_array(struct dhd_bus *bus)
DHD_ERROR(("%s: error %d on reading %d membytes" DHD_ERROR(("%s: error %d on reading %d membytes"
" at 0x%08x\n", " at 0x%08x\n",
__func__, bcmerror, MEMBLOCK, offset)); __func__, bcmerror, MEMBLOCK, offset));
goto err; goto free;
} }
offset += MEMBLOCK; offset += MEMBLOCK;
@ -5666,7 +5670,7 @@ static int dhdsdio_download_code_array(struct dhd_bus *bus)
DHD_ERROR(("%s: error %d on reading %d membytes at 0x%08x\n", DHD_ERROR(("%s: error %d on reading %d membytes at 0x%08x\n",
__func__, bcmerror, __func__, bcmerror,
sizeof(dlarray) - offset, offset)); sizeof(dlarray) - offset, offset));
goto err; goto free;
} }
} }
@ -5674,11 +5678,11 @@ static int dhdsdio_download_code_array(struct dhd_bus *bus)
DHD_ERROR(("%s: Downloaded image is corrupted.\n", DHD_ERROR(("%s: Downloaded image is corrupted.\n",
__func__)); __func__));
ASSERT(0); ASSERT(0);
goto err; goto free;
} else } else
DHD_ERROR(("%s: Download/Upload/Compare succeeded.\n", DHD_ERROR(("%s: Download/Upload/Compare succeeded.\n",
__func__)); __func__));
free:
kfree(ularray); kfree(ularray);
} }
#endif /* DHD_DEBUG */ #endif /* DHD_DEBUG */