fm10k: only prevent removal of default VID rules
This allows us to correctly add a VLAN even if it matches our default VID. However, we don't want to remove the VID rules once that VLAN is deleted. Correctly remove the stack layers information of the VLAN, but then return to forwarding that VID as untagged frames. If we deleted the VID rules here, we would begin dropping traffic due to VLAN membership violations. Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Tested-by: Krishneil Singh <krishneil.k.singh@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
parent
e40296628b
commit
56f0569e3a
|
@ -775,8 +775,8 @@ static int fm10k_update_vid(struct net_device *netdev, u16 vid, bool set)
|
|||
if (!set)
|
||||
clear_bit(vid, interface->active_vlans);
|
||||
|
||||
/* if default VLAN is already present do nothing */
|
||||
if (vid == hw->mac.default_vid)
|
||||
/* Do not remove default VID related entries from VLAN and MAC tables */
|
||||
if (!set && vid == hw->mac.default_vid)
|
||||
return 0;
|
||||
|
||||
fm10k_mbx_lock(interface);
|
||||
|
|
Loading…
Reference in New Issue