UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: vt6656: remove RX complete locking. 

The lock in vnt_submit_rx_urb_complete is blocked by TX activity.

The lock comes from a time when RX needed to be synchronized with
other parts of the driver because the WLAN API was in driver.

Since this is now dealt with in mac80211 the lock is unnecessary.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Malcolm Priestley 2015-09-27 09:17:44 +01:00 committed by Greg Kroah-Hartman
parent b914b49449
commit 56b4c04927
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/vt6656/usbpipe.c
View File

@ -168,7 +168,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
{ {
struct vnt_rcb *rcb = urb->context; struct vnt_rcb *rcb = urb->context;
struct vnt_private *priv = rcb->priv; struct vnt_private *priv = rcb->priv;
unsigned long flags;
switch (urb->status) { switch (urb->status) {
case 0: case 0:
@ -184,8 +183,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
} }
if (urb->actual_length) { if (urb->actual_length) {
spin_lock_irqsave(&priv->lock, flags);
if (vnt_rx_data(priv, rcb, urb->actual_length)) { if (vnt_rx_data(priv, rcb, urb->actual_length)) {
rcb->skb = dev_alloc_skb(priv->rx_buf_sz); rcb->skb = dev_alloc_skb(priv->rx_buf_sz);
if (!rcb->skb) { if (!rcb->skb) {
@ -193,7 +190,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
"Failed to re-alloc rx skb\n"); "Failed to re-alloc rx skb\n");
rcb->in_use = false; rcb->in_use = false;
spin_unlock_irqrestore(&priv->lock, flags);
return; return;
} }
} else { } else {
@ -203,8 +199,6 @@ static void vnt_submit_rx_urb_complete(struct urb *urb)
urb->transfer_buffer = skb_put(rcb->skb, urb->transfer_buffer = skb_put(rcb->skb,
skb_tailroom(rcb->skb)); skb_tailroom(rcb->skb));
spin_unlock_irqrestore(&priv->lock, flags);
} }
if (usb_submit_urb(urb, GFP_ATOMIC)) { if (usb_submit_urb(urb, GFP_ATOMIC)) {