SUNRPC: Optimize page release in svc_rdma_sendto()
Now that we have bulk page allocation and release APIs, it's more efficient to use those than it is for nfsd threads to wait for send completions. Previous patches have eliminated the calls to wait_for_completion() and complete(), in order to avoid scheduler overhead. Now release pages-under-I/O in the send completion handler using the efficient bulk release API. I've measured a 7% reduction in cumulative CPU utilization in svc_rdma_sendto(), svc_rdma_wc_send(), and svc_xprt_release(). In particular, using release_pages() instead of complete() cuts the time per svc_rdma_wc_send() call by two-thirds. This helps improve scalability because svc_rdma_wc_send() is single-threaded per connection. Reviewed-by: Tom Talpey <tom@talpey.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This commit is contained in:
parent
baf6d18b11
commit
5581cf8efc
|
@ -236,8 +236,8 @@ void svc_rdma_send_ctxt_put(struct svcxprt_rdma *rdma,
|
||||||
struct ib_device *device = rdma->sc_cm_id->device;
|
struct ib_device *device = rdma->sc_cm_id->device;
|
||||||
unsigned int i;
|
unsigned int i;
|
||||||
|
|
||||||
for (i = 0; i < ctxt->sc_page_count; ++i)
|
if (ctxt->sc_page_count)
|
||||||
put_page(ctxt->sc_pages[i]);
|
release_pages(ctxt->sc_pages, ctxt->sc_page_count);
|
||||||
|
|
||||||
/* The first SGE contains the transport header, which
|
/* The first SGE contains the transport header, which
|
||||||
* remains mapped until @ctxt is destroyed.
|
* remains mapped until @ctxt is destroyed.
|
||||||
|
|
Loading…
Reference in New Issue