UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

tty: n_gsm: Fix function naming and provide missing param descriptions 

Fixes the following W=1 kernel build warning(s):

 drivers/tty/n_gsm.c:525: warning: expecting prototype for gsm_stuff_packet(). Prototype was for gsm_stuff_frame() instead
 drivers/tty/n_gsm.c:1608: warning: expecting prototype for gsm_dlci_control(). Prototype was for gsm_dlci_command() instead
 drivers/tty/n_gsm.c:2561: warning: Function parameter or member 'cookie' not described in 'gsmld_read'
 drivers/tty/n_gsm.c:2561: warning: Function parameter or member 'offset' not described in 'gsmld_read'

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210520121906.3468725-11-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Lee Jones 2021-05-20 13:19:05 +01:00 committed by Greg Kroah-Hartman
parent 0e4b559735
commit 542a121aea
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/tty/n_gsm.c
View File

@ -512,7 +512,7 @@ static void gsm_print_packet(const char *hdr, int addr, int cr,
*/ */
/** /**
* gsm_stuff_packet - bytestuff a packet * gsm_stuff_frame - bytestuff a packet
* @input: input buffer * @input: input buffer
* @output: output buffer * @output: output buffer
* @len: length of input * @len: length of input
@ -1594,7 +1594,7 @@ static void gsm_dlci_data(struct gsm_dlci *dlci, const u8 *data, int clen)
} }
/** /**
* gsm_dlci_control - data arrived on control channel * gsm_dlci_command - data arrived on control channel
* @dlci: channel * @dlci: channel
* @data: block of bytes received * @data: block of bytes received
* @len: length of received block * @len: length of received block
@ -2557,6 +2557,8 @@ static void gsmld_write_wakeup(struct tty_struct *tty)
* @file: file object * @file: file object
* @buf: userspace buffer pointer * @buf: userspace buffer pointer
* @nr: size of I/O * @nr: size of I/O
* @cookie: unused
* @offset: unused
* *
* Perform reads for the line discipline. We are guaranteed that the * Perform reads for the line discipline. We are guaranteed that the
* line discipline will not be closed under us but we may get multiple * line discipline will not be closed under us but we may get multiple