UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

usb: typec: tipd: Move tps6598x_disconnect error path to its own label 

While the code currently correctly calls tps6598x_disconnect before jumping
to the error cleanup label it's inconsistent compared to all the other cleanup
actions and prone to introduce bugs if any more resources are added.

Signed-off-by: Sven Peter <sven@svenpeter.dev>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20221114174449.34634-4-sven@svenpeter.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Sven Peter 2022-11-14 18:44:49 +01:00 committed by Greg Kroah-Hartman
parent 4c8f27ba9e
commit 53a256ea95
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/typec/tipd/core.c
View File

@ -837,16 +837,16 @@ static int tps6598x_probe(struct i2c_client *client)
irq_handler, irq_handler,
IRQF_SHARED | IRQF_ONESHOT, IRQF_SHARED | IRQF_ONESHOT,
dev_name(&client->dev), tps); dev_name(&client->dev), tps);
if (ret) { if (ret)
tps6598x_disconnect(tps, 0); goto err_disconnect;
goto err_unregister_port;
}
i2c_set_clientdata(client, tps); i2c_set_clientdata(client, tps);
fwnode_handle_put(fwnode); fwnode_handle_put(fwnode);
return 0; return 0;
err_disconnect:
tps6598x_disconnect(tps, 0);
err_unregister_port: err_unregister_port:
typec_unregister_port(tps->port); typec_unregister_port(tps->port);
err_role_put: err_role_put: