drm/vmwgfx: Fix an uninitialized fence handle value

if vmw_execbuf_fence_commands() fails, The handle value will be
uninitialized and a bogus fence handle might be copied to user-space.

Cc: <stable@vger.kernel.org>
Fixes: 2724b2d54cda: ("drm/vmwgfx: Use new validation interface for the modesetting code v2")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com> #v1
Reviewed-by: Sinclair Yeh <syeh@vmware.com> #v1
Reviewed-by: Deepak Rawat <drawat@vmware.com>
This commit is contained in:
Thomas Hellstrom 2019-01-31 10:52:21 +01:00
parent 728354c005
commit 51fdbeb4ca
1 changed files with 2 additions and 2 deletions

View File

@ -2554,8 +2554,8 @@ void vmw_kms_helper_validation_finish(struct vmw_private *dev_priv,
user_fence_rep) user_fence_rep)
{ {
struct vmw_fence_obj *fence = NULL; struct vmw_fence_obj *fence = NULL;
uint32_t handle; uint32_t handle = 0;
int ret; int ret = 0;
if (file_priv || user_fence_rep || vmw_validation_has_bos(ctx) || if (file_priv || user_fence_rep || vmw_validation_has_bos(ctx) ||
out_fence) out_fence)