UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

RDMA/cxgb3: use WARN 

Use WARN rather than printk followed by WARN_ON(1), for conciseness.

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression list es;
@@

-printk(
+WARN(1,
  es);
-WARN_ON(1);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
This commit is contained in:
Julia Lawall 2012-11-03 10:58:29 +00:00 committed by Roland Dreier
parent c9795bd708
commit 5107c2a3d1
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/infiniband/hw/cxgb3/iwch_cm.c
View File

@ -128,9 +128,8 @@ static void stop_ep_timer(struct iwch_ep *ep)
{ {
PDBG("%s ep %p\n", __func__, ep); PDBG("%s ep %p\n", __func__, ep);
if (!timer_pending(&ep->timer)) { if (!timer_pending(&ep->timer)) {
printk(KERN_ERR "%s timer stopped when its not running! ep %p state %u\n", WARN(1, "%s timer stopped when its not running! ep %p state %u\n",
__func__, ep, ep->com.state); __func__, ep, ep->com.state);
WARN_ON(1);
return; return;
} }
del_timer_sync(&ep->timer); del_timer_sync(&ep->timer);
@ -1756,9 +1755,8 @@ static void ep_timeout(unsigned long arg)
__state_set(&ep->com, ABORTING); __state_set(&ep->com, ABORTING);
break; break;
default: default:
printk(KERN_ERR "%s unexpected state ep %p state %u\n", WARN(1, "%s unexpected state ep %p state %u\n",
__func__, ep, ep->com.state); __func__, ep, ep->com.state);
WARN_ON(1);
abort = 0; abort = 0;
} }
spin_unlock_irqrestore(&ep->com.lock, flags); spin_unlock_irqrestore(&ep->com.lock, flags);