linux-kselftest-fixes-6.6-rc4
This kselftest fixes update for Linux 6.6-rc4 consists of one single fix to unmount tracefs when test created mount. -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEPZKym/RZuOCGeA/kCwJExA0NQxwFAmUS9UQACgkQCwJExA0N QxyRPBAA6WuXhLQgZ5nHQtadXKXY3JxpheBfMcyCuaFbKDX4o1/+m66cs3k7lYN/ HUGBQEsmauF7cXoJ7aehyEvfgZWsHdaCNQW998ZuzpkOGREN0Wck8uleuqi3MVxb iL6WSurUt1Ka7b2m9s+Onz4+HQ/RmY/Ud9mHWwkpmRIxh4NItEGnUrdUn8uPBJ0X M3/PrfxaA92b3WYeSNkj+QB78PkLgaEw4pBUNBnozMcyD9G6yH+zygx3svwoCArM 7jKntK+juKvscC8rDQJwRDTFzeQv/a9GSa5WBnye1zyPIiM8wB6FT0h365eFPM0t Y0aikQcG7cof6WmMRZ/L9WEJ73mGhGmKCmJGEUkHd/VrAAD76aDfP5hmBqIFVpQk x6pzb3e88LVne8x/VpN6uawtNVPGZUFOYrYkDNXVPfQ2u0S0VAWyAlSnJl2QA5hp TRBa75fXw/ERLDmpDTNbHZfLmEOoTS9Sr6Phbg7a0jk4fsmsbVz6iN9HJnBBWGKz KMRZaVhR/CdANBh0cJ5U9+i1VnqbTX2J7F34qwBOMQ3VHAQRSxP/FNPPVBbQdSRl q3dCPZnFmKZ7+VCGWCPLwA55TjzCaQldH18NelCCfbaAHvoEcMZV0NaKDOcghNEe t0g1yJ74P9T60UvrIUys6Wg240B3TpDmixeP5TfWfFOppLEm6Lg= =5LK8 -----END PGP SIGNATURE----- Merge tag 'linux-kselftest-fixes-6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest Pull kselftest fix from Shuah Khan: "One single fix to unmount tracefs when test created mount" * tag 'linux-kselftest-fixes-6.6-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest: selftests/user_events: Fix to unmount tracefs when test created mount
This commit is contained in:
commit
50768a425b
|
@ -91,16 +91,18 @@ static int reg_disable(long *enable, int bit)
|
|||
|
||||
FIXTURE(user) {
|
||||
long check;
|
||||
bool umount;
|
||||
};
|
||||
|
||||
FIXTURE_SETUP(user) {
|
||||
USER_EVENT_FIXTURE_SETUP(return);
|
||||
USER_EVENT_FIXTURE_SETUP(return, self->umount);
|
||||
|
||||
change_event(false);
|
||||
self->check = 0;
|
||||
}
|
||||
|
||||
FIXTURE_TEARDOWN(user) {
|
||||
USER_EVENT_FIXTURE_TEARDOWN(self->umount);
|
||||
}
|
||||
|
||||
TEST_F(user, enablement) {
|
||||
|
|
|
@ -144,13 +144,16 @@ do { \
|
|||
|
||||
FIXTURE(user) {
|
||||
int check;
|
||||
bool umount;
|
||||
};
|
||||
|
||||
FIXTURE_SETUP(user) {
|
||||
USER_EVENT_FIXTURE_SETUP(return);
|
||||
USER_EVENT_FIXTURE_SETUP(return, self->umount);
|
||||
}
|
||||
|
||||
FIXTURE_TEARDOWN(user) {
|
||||
USER_EVENT_FIXTURE_TEARDOWN(self->umount);
|
||||
|
||||
wait_for_delete();
|
||||
}
|
||||
|
||||
|
|
|
@ -204,10 +204,11 @@ FIXTURE(user) {
|
|||
int data_fd;
|
||||
int enable_fd;
|
||||
int check;
|
||||
bool umount;
|
||||
};
|
||||
|
||||
FIXTURE_SETUP(user) {
|
||||
USER_EVENT_FIXTURE_SETUP(return);
|
||||
USER_EVENT_FIXTURE_SETUP(return, self->umount);
|
||||
|
||||
self->status_fd = open(status_file, O_RDONLY);
|
||||
ASSERT_NE(-1, self->status_fd);
|
||||
|
@ -219,6 +220,8 @@ FIXTURE_SETUP(user) {
|
|||
}
|
||||
|
||||
FIXTURE_TEARDOWN(user) {
|
||||
USER_EVENT_FIXTURE_TEARDOWN(self->umount);
|
||||
|
||||
close(self->status_fd);
|
||||
close(self->data_fd);
|
||||
|
||||
|
|
|
@ -111,16 +111,19 @@ static int clear(int *check)
|
|||
FIXTURE(user) {
|
||||
int data_fd;
|
||||
int check;
|
||||
bool umount;
|
||||
};
|
||||
|
||||
FIXTURE_SETUP(user) {
|
||||
USER_EVENT_FIXTURE_SETUP(return);
|
||||
USER_EVENT_FIXTURE_SETUP(return, self->umount);
|
||||
|
||||
self->data_fd = open(data_file, O_RDWR);
|
||||
ASSERT_NE(-1, self->data_fd);
|
||||
}
|
||||
|
||||
FIXTURE_TEARDOWN(user) {
|
||||
USER_EVENT_FIXTURE_TEARDOWN(self->umount);
|
||||
|
||||
close(self->data_fd);
|
||||
|
||||
if (clear(&self->check) != 0)
|
||||
|
|
|
@ -11,13 +11,19 @@
|
|||
|
||||
#include "../kselftest.h"
|
||||
|
||||
static inline bool tracefs_enabled(char **message, bool *fail)
|
||||
static inline void tracefs_unmount(void)
|
||||
{
|
||||
umount("/sys/kernel/tracing");
|
||||
}
|
||||
|
||||
static inline bool tracefs_enabled(char **message, bool *fail, bool *umount)
|
||||
{
|
||||
struct stat buf;
|
||||
int ret;
|
||||
|
||||
*message = "";
|
||||
*fail = false;
|
||||
*umount = false;
|
||||
|
||||
/* Ensure tracefs is installed */
|
||||
ret = stat("/sys/kernel/tracing", &buf);
|
||||
|
@ -37,6 +43,8 @@ static inline bool tracefs_enabled(char **message, bool *fail)
|
|||
return false;
|
||||
}
|
||||
|
||||
*umount = true;
|
||||
|
||||
ret = stat("/sys/kernel/tracing/README", &buf);
|
||||
}
|
||||
|
||||
|
@ -49,13 +57,14 @@ static inline bool tracefs_enabled(char **message, bool *fail)
|
|||
return true;
|
||||
}
|
||||
|
||||
static inline bool user_events_enabled(char **message, bool *fail)
|
||||
static inline bool user_events_enabled(char **message, bool *fail, bool *umount)
|
||||
{
|
||||
struct stat buf;
|
||||
int ret;
|
||||
|
||||
*message = "";
|
||||
*fail = false;
|
||||
*umount = false;
|
||||
|
||||
if (getuid() != 0) {
|
||||
*message = "Must be run as root";
|
||||
|
@ -63,7 +72,7 @@ static inline bool user_events_enabled(char **message, bool *fail)
|
|||
return false;
|
||||
}
|
||||
|
||||
if (!tracefs_enabled(message, fail))
|
||||
if (!tracefs_enabled(message, fail, umount))
|
||||
return false;
|
||||
|
||||
/* Ensure user_events is installed */
|
||||
|
@ -85,10 +94,10 @@ static inline bool user_events_enabled(char **message, bool *fail)
|
|||
return true;
|
||||
}
|
||||
|
||||
#define USER_EVENT_FIXTURE_SETUP(statement) do { \
|
||||
#define USER_EVENT_FIXTURE_SETUP(statement, umount) do { \
|
||||
char *message; \
|
||||
bool fail; \
|
||||
if (!user_events_enabled(&message, &fail)) { \
|
||||
if (!user_events_enabled(&message, &fail, &(umount))) { \
|
||||
if (fail) { \
|
||||
TH_LOG("Setup failed due to: %s", message); \
|
||||
ASSERT_FALSE(fail); \
|
||||
|
@ -97,4 +106,9 @@ static inline bool user_events_enabled(char **message, bool *fail)
|
|||
} \
|
||||
} while (0)
|
||||
|
||||
#define USER_EVENT_FIXTURE_TEARDOWN(umount) do { \
|
||||
if ((umount)) \
|
||||
tracefs_unmount(); \
|
||||
} while (0)
|
||||
|
||||
#endif /* _USER_EVENTS_SELFTESTS_H */
|
||||
|
|
Loading…
Reference in New Issue