UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

drivers/w1/w1_int.c: call put_device if device_register fails 

Currently, memsetting and kfreeing the device is bad behaviour.  The
device will have a reference count of 1 and hence can cause trouble
because it has kfree'd.  Proper way to handle a failed device_register is
to call put_device right after it fails.

Signed-off-by: Levente Kurusa <levex@linux.com>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Levente Kurusa 2015-09-14 10:56:12 -07:00 committed by Greg Kroah-Hartman
parent 7c22e645cd
commit 5052436dcb
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/w1/w1_int.c
View File

@ -91,8 +91,7 @@ static struct w1_master *w1_alloc_dev(u32 id, int slave_count, int slave_ttl,
err = device_register(&dev->dev); err = device_register(&dev->dev);
if (err) { if (err) {
pr_err("Failed to register master device. err=%d\n", err); pr_err("Failed to register master device. err=%d\n", err);
memset(dev, 0, sizeof(struct w1_master)); put_device(&dev->dev);
kfree(dev);
dev = NULL; dev = NULL;
} }