UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ext4: mballoc: make ext4_mb_use_preallocated() return type as bool 

Change return type of function ext4_mb_use_preallocated() to bool to
better reflect what this function can return.

There should be no functionality change in this patch.

Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
Link: https://lore.kernel.org/r/7880cb6ef911465beafefcd7e9c3ea214688744b.1589086800.git.riteshh@linux.ibm.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Ritesh Harjani 2020-05-10 11:54:47 +05:30 committed by Theodore Ts'o
parent f283529aba
commit 4fca8f0779
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
fs/ext4/mballoc.c
View File

@ -3432,7 +3432,7 @@ ext4_mb_check_group_pa(ext4_fsblk_t goal_block,
/* /*
* search goal blocks in preallocated space * search goal blocks in preallocated space
*/ */
static noinline_for_stack int static noinline_for_stack bool
ext4_mb_use_preallocated(struct ext4_allocation_context *ac) ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
{ {
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb); struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
@ -3444,7 +3444,7 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
/* only data can be preallocated */ /* only data can be preallocated */
if (!(ac->ac_flags & EXT4_MB_HINT_DATA)) if (!(ac->ac_flags & EXT4_MB_HINT_DATA))
return 0; return false;
/* first, try per-file preallocation */ /* first, try per-file preallocation */
rcu_read_lock(); rcu_read_lock();
@ -3471,7 +3471,7 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
spin_unlock(&pa->pa_lock); spin_unlock(&pa->pa_lock);
ac->ac_criteria = 10; ac->ac_criteria = 10;
rcu_read_unlock(); rcu_read_unlock();
return 1; return true;
} }
spin_unlock(&pa->pa_lock); spin_unlock(&pa->pa_lock);
} }
@ -3479,12 +3479,12 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
/* can we use group allocation? */ /* can we use group allocation? */
if (!(ac->ac_flags & EXT4_MB_HINT_GROUP_ALLOC)) if (!(ac->ac_flags & EXT4_MB_HINT_GROUP_ALLOC))
return 0; return false;
/* inode may have no locality group for some reason */ /* inode may have no locality group for some reason */
lg = ac->ac_lg; lg = ac->ac_lg;
if (lg == NULL) if (lg == NULL)
return 0; return false;
order = fls(ac->ac_o_ex.fe_len) - 1; order = fls(ac->ac_o_ex.fe_len) - 1;
if (order > PREALLOC_TB_SIZE - 1) if (order > PREALLOC_TB_SIZE - 1)
/* The max size of hash table is PREALLOC_TB_SIZE */ /* The max size of hash table is PREALLOC_TB_SIZE */
@ -3513,9 +3513,9 @@ ext4_mb_use_preallocated(struct ext4_allocation_context *ac)
if (cpa) { if (cpa) {
ext4_mb_use_group_pa(ac, cpa); ext4_mb_use_group_pa(ac, cpa);
ac->ac_criteria = 20; ac->ac_criteria = 20;
return 1; return true;
} }
return 0; return false;
} }
/* /*