UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

mm/mempool: allow NULL `pool' pointer in mempool_destroy() 

mempool_destroy() does not tolerate a NULL mempool_t pointer argument and
performs a NULL-pointer dereference.  This requires additional attention
and effort from developers/reviewers and forces all mempool_destroy()
callers to do a NULL check

    if (pool)
        mempool_destroy(pool);

Or, otherwise, be invalid mempool_destroy() users.

Tweak mempool_destroy() and NULL-check the pointer there.

Proposed by Andrew Morton.

Link: https://lkml.org/lkml/2015/6/8/583
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Sergey Senozhatsky 2015-09-08 15:00:53 -07:00 committed by Linus Torvalds
parent 3942d29918
commit 4e3ca3e033
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mm/mempool.c
View File

@ -150,6 +150,9 @@ static void *remove_element(mempool_t *pool)
*/ */
void mempool_destroy(mempool_t *pool) void mempool_destroy(mempool_t *pool)
{ {
if (unlikely(!pool))
return;
while (pool->curr_nr) { while (pool->curr_nr) {
void *element = remove_element(pool); void *element = remove_element(pool);
pool->free(element, pool->pool_data); pool->free(element, pool->pool_data);