UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

ksmbd: clear RENAME_NOREPLACE before calling vfs_rename 

commit 4973b04d3ea577db80c501c5f14e68ec69fe1794 upstream.

File overwrite case is explicitly handled, so it is not necessary to
pass RENAME_NOREPLACE to vfs_rename.

Clearing the flag fixes rename operations when the share is a ntfs-3g
mount. The latter uses an older version of fuse with no support for
flags in the ->rename op.

Cc: stable@vger.kernel.org
Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Marios Makassikis 2024-04-15 15:12:48 +02:00 committed by Greg Kroah-Hartman
parent 5c20b242d4
commit 4cbb88351b
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/smb/server/vfs.c
View File

@ -745,10 +745,15 @@ retry:
goto out4; goto out4;
} }
/*
* explicitly handle file overwrite case, for compatibility with
* filesystems that may not support rename flags (e.g: fuse)
*/
if ((flags & RENAME_NOREPLACE) && d_is_positive(new_dentry)) { if ((flags & RENAME_NOREPLACE) && d_is_positive(new_dentry)) {
err = -EEXIST; err = -EEXIST;
goto out4; goto out4;
} }
flags &= ~(RENAME_NOREPLACE);
if (old_child == trap) { if (old_child == trap) {
err = -EINVAL; err = -EINVAL;