UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

iio: magn: hmc5843: Make hmc5843_common_remove() return void 

Up to now hmc5843_common_remove() returns zero unconditionally. Make it
return void instead which makes it easier to see in the callers that
there is no error to handle.

Also the return value of i2c and spi remove callbacks is ignored anyway.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/20211013203223.2694577-14-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Uwe Kleine-König 2021-10-13 22:32:21 +02:00 committed by Jonathan Cameron
parent c7143c49c6
commit 4b6fb9f3e9
4 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/iio/magnetometer/hmc5843.h
View File

@ -50,7 +50,7 @@ struct hmc5843_data {
int hmc5843_common_probe(struct device *dev, struct regmap *regmap,
enum hmc5843_ids id, const char *name);
int hmc5843_common_remove(struct device *dev);
void hmc5843_common_remove(struct device *dev);
int hmc5843_common_suspend(struct device *dev);
int hmc5843_common_resume(struct device *dev);

4
drivers/iio/magnetometer/hmc5843_core.c
View File

@ -671,7 +671,7 @@ buffer_setup_err:
}
EXPORT_SYMBOL(hmc5843_common_probe);
int hmc5843_common_remove(struct device *dev)
void hmc5843_common_remove(struct device *dev)
{
struct iio_dev *indio_dev = dev_get_drvdata(dev);
@ -680,8 +680,6 @@ int hmc5843_common_remove(struct device *dev)
/* sleep mode to save power */
hmc5843_set_mode(iio_priv(indio_dev), HMC5843_MODE_SLEEP);
return 0;
}
EXPORT_SYMBOL(hmc5843_common_remove);

4
drivers/iio/magnetometer/hmc5843_i2c.c
View File

@ -67,7 +67,9 @@ static int hmc5843_i2c_probe(struct i2c_client *cli,
static int hmc5843_i2c_remove(struct i2c_client *client)
{
return hmc5843_common_remove(&client->dev);
hmc5843_common_remove(&client->dev);
return 0;
}
static const struct i2c_device_id hmc5843_id[] = {

4
drivers/iio/magnetometer/hmc5843_spi.c
View File

@ -76,7 +76,9 @@ static int hmc5843_spi_probe(struct spi_device *spi)
static int hmc5843_spi_remove(struct spi_device *spi)
{
return hmc5843_common_remove(&spi->dev);
hmc5843_common_remove(&spi->dev);
return 0;
}
static const struct spi_device_id hmc5843_id[] = {