crypto: qce - fix uaf on qce_aead_register_one
Pointer alg points to sub field of tmpl, it
is dereferenced after tmpl is freed. Fix
this by accessing alg before free tmpl.
Fixes: 9363efb4
("crypto: qce - Add support for AEAD algorithms")
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Acked-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
574c833ef3
commit
4a9dbd0219
|
@ -802,8 +802,8 @@ static int qce_aead_register_one(const struct qce_aead_def *def, struct qce_devi
|
||||||
|
|
||||||
ret = crypto_register_aead(alg);
|
ret = crypto_register_aead(alg);
|
||||||
if (ret) {
|
if (ret) {
|
||||||
kfree(tmpl);
|
|
||||||
dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name);
|
dev_err(qce->dev, "%s registration failed\n", alg->base.cra_name);
|
||||||
|
kfree(tmpl);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue