clk: imx: pll14xx: Use register defines consistently
The driver has defines for the registers, but they are mostly unused. Use the defines consistently throughout the driver. While at it rename DIV_CTL to DIV_CTL0 because that's the name in the reference manual. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Reviewed-by: Abel Vesa <abel.vesa@nxp.com> Link: https://lore.kernel.org/r/20220304125256.2125023-2-s.hauer@pengutronix.de Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
This commit is contained in:
parent
d097cc045b
commit
485b4ff57c
|
@ -15,7 +15,8 @@
|
|||
#include "clk.h"
|
||||
|
||||
#define GNRL_CTL 0x0
|
||||
#define DIV_CTL 0x4
|
||||
#define DIV_CTL0 0x4
|
||||
#define DIV_CTL1 0x8
|
||||
#define LOCK_STATUS BIT(31)
|
||||
#define LOCK_SEL_MASK BIT(29)
|
||||
#define CLKE_MASK BIT(11)
|
||||
|
@ -122,7 +123,7 @@ static unsigned long clk_pll1416x_recalc_rate(struct clk_hw *hw,
|
|||
u32 mdiv, pdiv, sdiv, pll_div;
|
||||
u64 fvco = parent_rate;
|
||||
|
||||
pll_div = readl_relaxed(pll->base + 4);
|
||||
pll_div = readl_relaxed(pll->base + DIV_CTL0);
|
||||
mdiv = (pll_div & MDIV_MASK) >> MDIV_SHIFT;
|
||||
pdiv = (pll_div & PDIV_MASK) >> PDIV_SHIFT;
|
||||
sdiv = (pll_div & SDIV_MASK) >> SDIV_SHIFT;
|
||||
|
@ -141,8 +142,8 @@ static unsigned long clk_pll1443x_recalc_rate(struct clk_hw *hw,
|
|||
short int kdiv;
|
||||
u64 fvco = parent_rate;
|
||||
|
||||
pll_div_ctl0 = readl_relaxed(pll->base + 4);
|
||||
pll_div_ctl1 = readl_relaxed(pll->base + 8);
|
||||
pll_div_ctl0 = readl_relaxed(pll->base + DIV_CTL0);
|
||||
pll_div_ctl1 = readl_relaxed(pll->base + DIV_CTL1);
|
||||
mdiv = (pll_div_ctl0 & MDIV_MASK) >> MDIV_SHIFT;
|
||||
pdiv = (pll_div_ctl0 & PDIV_MASK) >> PDIV_SHIFT;
|
||||
sdiv = (pll_div_ctl0 & SDIV_MASK) >> SDIV_SHIFT;
|
||||
|
@ -172,7 +173,7 @@ static int clk_pll14xx_wait_lock(struct clk_pll14xx *pll)
|
|||
{
|
||||
u32 val;
|
||||
|
||||
return readl_poll_timeout(pll->base, val, val & LOCK_STATUS, 0,
|
||||
return readl_poll_timeout(pll->base + GNRL_CTL, val, val & LOCK_STATUS, 0,
|
||||
LOCK_TIMEOUT_US);
|
||||
}
|
||||
|
||||
|
@ -191,32 +192,32 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate,
|
|||
return -EINVAL;
|
||||
}
|
||||
|
||||
tmp = readl_relaxed(pll->base + 4);
|
||||
tmp = readl_relaxed(pll->base + DIV_CTL0);
|
||||
|
||||
if (!clk_pll14xx_mp_change(rate, tmp)) {
|
||||
tmp &= ~(SDIV_MASK) << SDIV_SHIFT;
|
||||
tmp |= rate->sdiv << SDIV_SHIFT;
|
||||
writel_relaxed(tmp, pll->base + 4);
|
||||
writel_relaxed(tmp, pll->base + DIV_CTL0);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* Bypass clock and set lock to pll output lock */
|
||||
tmp = readl_relaxed(pll->base);
|
||||
tmp = readl_relaxed(pll->base + GNRL_CTL);
|
||||
tmp |= LOCK_SEL_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
/* Enable RST */
|
||||
tmp &= ~RST_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
/* Enable BYPASS */
|
||||
tmp |= BYPASS_MASK;
|
||||
writel(tmp, pll->base);
|
||||
writel(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
div_val = (rate->mdiv << MDIV_SHIFT) | (rate->pdiv << PDIV_SHIFT) |
|
||||
(rate->sdiv << SDIV_SHIFT);
|
||||
writel_relaxed(div_val, pll->base + 0x4);
|
||||
writel_relaxed(div_val, pll->base + DIV_CTL0);
|
||||
|
||||
/*
|
||||
* According to SPEC, t3 - t2 need to be greater than
|
||||
|
@ -228,7 +229,7 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate,
|
|||
|
||||
/* Disable RST */
|
||||
tmp |= RST_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
/* Wait Lock */
|
||||
ret = clk_pll14xx_wait_lock(pll);
|
||||
|
@ -237,7 +238,7 @@ static int clk_pll1416x_set_rate(struct clk_hw *hw, unsigned long drate,
|
|||
|
||||
/* Bypass */
|
||||
tmp &= ~BYPASS_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
@ -257,32 +258,32 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
|
|||
return -EINVAL;
|
||||
}
|
||||
|
||||
tmp = readl_relaxed(pll->base + 4);
|
||||
tmp = readl_relaxed(pll->base + DIV_CTL0);
|
||||
|
||||
if (!clk_pll14xx_mp_change(rate, tmp)) {
|
||||
tmp &= ~(SDIV_MASK) << SDIV_SHIFT;
|
||||
tmp |= rate->sdiv << SDIV_SHIFT;
|
||||
writel_relaxed(tmp, pll->base + 4);
|
||||
writel_relaxed(tmp, pll->base + DIV_CTL0);
|
||||
|
||||
tmp = rate->kdiv << KDIV_SHIFT;
|
||||
writel_relaxed(tmp, pll->base + 8);
|
||||
writel_relaxed(tmp, pll->base + DIV_CTL1);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* Enable RST */
|
||||
tmp = readl_relaxed(pll->base);
|
||||
tmp = readl_relaxed(pll->base + GNRL_CTL);
|
||||
tmp &= ~RST_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
/* Enable BYPASS */
|
||||
tmp |= BYPASS_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
div_val = (rate->mdiv << MDIV_SHIFT) | (rate->pdiv << PDIV_SHIFT) |
|
||||
(rate->sdiv << SDIV_SHIFT);
|
||||
writel_relaxed(div_val, pll->base + 0x4);
|
||||
writel_relaxed(rate->kdiv << KDIV_SHIFT, pll->base + 0x8);
|
||||
writel_relaxed(div_val, pll->base + DIV_CTL0);
|
||||
writel_relaxed(rate->kdiv << KDIV_SHIFT, pll->base + DIV_CTL1);
|
||||
|
||||
/*
|
||||
* According to SPEC, t3 - t2 need to be greater than
|
||||
|
@ -294,7 +295,7 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
|
|||
|
||||
/* Disable RST */
|
||||
tmp |= RST_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
/* Wait Lock*/
|
||||
ret = clk_pll14xx_wait_lock(pll);
|
||||
|
@ -303,7 +304,7 @@ static int clk_pll1443x_set_rate(struct clk_hw *hw, unsigned long drate,
|
|||
|
||||
/* Bypass */
|
||||
tmp &= ~BYPASS_MASK;
|
||||
writel_relaxed(tmp, pll->base);
|
||||
writel_relaxed(tmp, pll->base + GNRL_CTL);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue