cfq-iosched: no dispatch limit for single queue

Since commit 2f5cb7381b, each queue can send
up to 4 * 4 requests if only one queue exists. I wonder why we have such limit.
Device supports tag can send more requests. For example, AHCI can send 31
requests. Test (direct aio randread) shows the limits reduce about 4% disk
thoughput.
On the other hand, since we send one request one time, if other queue
pop when current is sending more than cfq_quantum requests, current queue will
stop send requests soon after one request, so sounds there is no big latency.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Shaohua Li 2009-12-03 12:58:05 +01:00 committed by Jens Axboe
parent 98262f2762
commit 474b18ccc2
1 changed files with 2 additions and 2 deletions

View File

@ -1618,9 +1618,9 @@ static bool cfq_may_dispatch(struct cfq_data *cfqd, struct cfq_queue *cfqq)
return false;
/*
* Sole queue user, allow bigger slice
* Sole queue user, no limit
*/
max_dispatch *= 4;
max_dispatch = -1;
}
/*