regulator: Remove dev_err() usage after platform_get_irq()
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // <smpl> @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // </smpl> While we're here, remove braces on if statements that only have one statement (manually). Cc: Liam Girdwood <lgirdwood@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20190730181557.90391-38-swboyd@chromium.org Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
1889c6e6ac
commit
47241933b4
|
@ -1032,10 +1032,8 @@ static int da9062_regulator_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
/* LDOs overcurrent event support */
|
/* LDOs overcurrent event support */
|
||||||
irq = platform_get_irq_byname(pdev, "LDO_LIM");
|
irq = platform_get_irq_byname(pdev, "LDO_LIM");
|
||||||
if (irq < 0) {
|
if (irq < 0)
|
||||||
dev_err(&pdev->dev, "Failed to get IRQ.\n");
|
|
||||||
return irq;
|
return irq;
|
||||||
}
|
|
||||||
regulators->irq_ldo_lim = irq;
|
regulators->irq_ldo_lim = irq;
|
||||||
|
|
||||||
ret = devm_request_threaded_irq(&pdev->dev, irq,
|
ret = devm_request_threaded_irq(&pdev->dev, irq,
|
||||||
|
|
|
@ -863,10 +863,8 @@ static int da9063_regulator_probe(struct platform_device *pdev)
|
||||||
|
|
||||||
/* LDOs overcurrent event support */
|
/* LDOs overcurrent event support */
|
||||||
irq = platform_get_irq_byname(pdev, "LDO_LIM");
|
irq = platform_get_irq_byname(pdev, "LDO_LIM");
|
||||||
if (irq < 0) {
|
if (irq < 0)
|
||||||
dev_err(&pdev->dev, "Failed to get IRQ.\n");
|
|
||||||
return irq;
|
return irq;
|
||||||
}
|
|
||||||
|
|
||||||
ret = devm_request_threaded_irq(&pdev->dev, irq,
|
ret = devm_request_threaded_irq(&pdev->dev, irq,
|
||||||
NULL, da9063_ldo_lim_event,
|
NULL, da9063_ldo_lim_event,
|
||||||
|
|
Loading…
Reference in New Issue