UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

dmaengine: pl330: explicitly freeup irq 

dmaengine device should explicitly call devm_free_irq() when using
devm_request_irq().

The irq is still ON when devices remove is executed and irq should be
quiesced before remove is completed.

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Vinod Koul 2016-07-05 10:02:16 +05:30
parent 898dbbf65f
commit 46cf94d6ab
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/pl330.c
View File

@ -3002,12 +3002,18 @@ static int pl330_remove(struct amba_device *adev)
{ {
struct pl330_dmac *pl330 = amba_get_drvdata(adev); struct pl330_dmac *pl330 = amba_get_drvdata(adev);
struct dma_pl330_chan *pch, *_p; struct dma_pl330_chan *pch, *_p;
int i, irq;
pm_runtime_get_noresume(pl330->ddma.dev); pm_runtime_get_noresume(pl330->ddma.dev);
if (adev->dev.of_node) if (adev->dev.of_node)
of_dma_controller_free(adev->dev.of_node); of_dma_controller_free(adev->dev.of_node);
for (i = 0; i < AMBA_NR_IRQS; i++) {
irq = adev->irq[i];
devm_free_irq(&adev->dev, irq, pl330);
}
dma_async_device_unregister(&pl330->ddma); dma_async_device_unregister(&pl330->ddma);
/* Idle the DMAC */ /* Idle the DMAC */