UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

bpf: Use kmemdup() to replace kmalloc + memcpy 

Eliminate the follow coccicheck warning:

./kernel/bpf/btf.c:6537:13-20: WARNING opportunity for kmemdup.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/1639030882-92383-1-git-send-email-jiapeng.chong@linux.alibaba.com
This commit is contained in:
Jiapeng Chong 2021-12-09 14:21:22 +08:00 committed by Alexei Starovoitov
parent 84ef3f0bb7
commit 4674f21071
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kernel/bpf/btf.c
View File

@ -6534,12 +6534,11 @@ static struct bpf_cand_cache *populate_cand_cache(struct bpf_cand_cache *cands,
bpf_free_cands_from_cache(*cc); bpf_free_cands_from_cache(*cc);
*cc = NULL; *cc = NULL;
} }
new_cands = kmalloc(sizeof_cands(cands->cnt), GFP_KERNEL); new_cands = kmemdup(cands, sizeof_cands(cands->cnt), GFP_KERNEL);
if (!new_cands) { if (!new_cands) {
bpf_free_cands(cands); bpf_free_cands(cands);
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
} }
memcpy(new_cands, cands, sizeof_cands(cands->cnt));
/* strdup the name, since it will stay in cache. /* strdup the name, since it will stay in cache.
* the cands->name points to strings in prog's BTF and the prog can be unloaded. * the cands->name points to strings in prog's BTF and the prog can be unloaded.
*/ */