UbiquitousOS
/
OpenCloudOS-Kernel
mirror of https://gitee.com/OpenCloudOS/OpenCloudOS-Kernel.git
11
0
Fork 0
Code Issues Projects Releases Wiki Activity

affs: fix a memory leak in affs_remount 

In affs_remount if data is provided it is duplicated into new_opts.  The
allocated memory for new_opts is only released if parse_options fails.

There's a bit of history behind new_options, originally there was
save/replace options on the VFS layer so the 'data' passed must not
change (thus strdup), this got cleaned up in later patches. But not
completely.

There's no reason to do the strdup in cases where the filesystem does
not need to reuse the 'data' again, because strsep would modify it
directly.

Fixes: c8f33d0bec ("affs: kstrdup() memory handling")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
[ update changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Navid Emamdoost 2019-10-02 16:52:37 -05:00 committed by David Sterba
parent 6060c07d47
commit 450c3d4166
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/affs/super.c
View File

@ -561,14 +561,9 @@ affs_remount(struct super_block *sb, int *flags, char *data)
int root_block; int root_block;
unsigned long mount_flags; unsigned long mount_flags;
int res = 0; int res = 0;
char *new_opts;
char volume[32]; char volume[32];
char *prefix = NULL; char *prefix = NULL;
new_opts = kstrdup(data, GFP_KERNEL);
if (data && !new_opts)
return -ENOMEM;
pr_debug("%s(flags=0x%x,opts=\"%s\")\n", __func__, *flags, data); pr_debug("%s(flags=0x%x,opts=\"%s\")\n", __func__, *flags, data);
sync_filesystem(sb); sync_filesystem(sb);
@ -579,7 +574,6 @@ affs_remount(struct super_block *sb, int *flags, char *data)
&blocksize, &prefix, volume, &blocksize, &prefix, volume,
&mount_flags)) { &mount_flags)) {
kfree(prefix); kfree(prefix);
kfree(new_opts);
return -EINVAL; return -EINVAL;
} }